feature: href for logo (with optional target="_blank") #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breftejk
changed the title
|
the tests are failing |
Uzlopak
previously requested changes
Aug 9, 2024
Co-authored-by: Aras Abbasi <aras.abbasi@googlemail.com> Signed-off-by: Marcin Kondrat <marcin.kondrat@assts.tech>
Co-authored-by: Aras Abbasi <aras.abbasi@googlemail.com> Signed-off-by: Marcin Kondrat <marcin.kondrat@assts.tech>
Uzlopak
reviewed
Aug 19, 2024
|
What is with this test error? I dont get it. Everything's fine on my test yet still this weird error on GitHub. It doesn't even tell you the reason to be backtracked. |
|
Ignore the |
|
@climba03003 PTAL |
climba03003
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm run testandnpm run benchmarkand the Code of conduct