test: migrate from tap to node:test and c8

[R-Campbell]

A few decisions while converting tests:

• t.same and t.match were converted to t.assert.deepEqual.
• t.strictSame was converted to t.assert.deepStrictEqual.
• t.notOk was converted to t.assert.equal comparing the coerced value (using !!) to false. We could have done t.assert.ok(${value} === false) but using equal with false felt more in the spirit of checking that for things that are not ok.
• t.pass was converted to t.assert.ok(true, ${originalMessage})
• Snapshots were removed and copied into the appropriate tests.

Checklist

• run npm run test
• tests and/or benchmarks are included
• documentation is changed or added
• commit message and code follows the Developer's Certification of Origin
  and the Code of conduct

[dancastillo]

Can you update t.assert.equal to t.assert.strictEqual and t.assert.deepEqual to t.assert.deepStrictEqual

[dancastillo]

Might be worth keeping this around for a bit just in case for people who ran tests

[R-Campbell]

I made that update but ran into an issue with the Symbol that json-schema-resolver adds to the schema (specifically json-schema-resolver.ignore) and couldn't find a great way to reference that in the testing code. Instead I used JSON.parse(JSON.stringify(...)) to strip the Symbols from the schema objects where needed (see here for an example). I don't know if that's the best solution, but it works.

I also found some places where null needed to be updated to undefined (see here for an example) as well as t.fail calls that I missed and changed to t.assert.fail.

[dancastillo]

Lets removed the !! to do a strict assert of undefined like this t.assert.strictEqual(!!value, undefined)t.assert.strictEqual(value, undefined)` this will help explain behavior IMHO

[dancastillo]

this works without JSON.parse(JSON.stringify(...)

[dancastillo]

this works without JSON.parse(JSON.stringify(...)

[dancastillo]

I made that update but ran into an issue with the Symbol that json-schema-resolver adds to the schema (specifically json-schema-resolver.ignore) and couldn't find a great way to reference that in the testing code. Instead I used JSON.parse(JSON.stringify(...)) to strip the Symbols from the schema objects where needed (see here for an example). I don't know if that's the best solution, but it works.

I also found some places where null needed to be updated to undefined (see here for an example) as well as t.fail calls that I missed and changed to t.assert.fail.

@Eomm wdyt here - JSON.parse(JSON.stringify(...)) does remove the symbol from the object. Wondering if there is a preferred way to handle this?