build(deps): revert to peerDependency, refer to #73

[nadhifikbarw]

Checklist

• run npm run test and npm run benchmark
• tests and/or benchmarks are included
• documentation is changed or added
• commit message and code follows the Developer's Certification of Origin
  and the Code of conduct

This is peerDependency revert fix version mentioned for #73

[RafaelGSS]

We should mention in the docs users should now install @synclair/typebox by themselves.

[nadhifikbarw]

@RafaelGSS i updated the readme for it

[RafaelGSS]

PTAL @mcollina

[nadhifikbarw]

@RafaelGSS would you mind to help check my approach for @mcollina testing concerns mentioned in #63 , I tried extending the testing workflow to perform cross peer dependency versions testing that would ease the need to specify wider version of Typebox for example ^0.26.0

https://github.com/nadhifikbarw/fastify-type-provider-typebox/tree/next

The downside is having test job numbers increase exponentially the wider the test range is for obv reason, but otherwise it's simplest approach i could think of.

Example tests run
https://github.com/nadhifikbarw/fastify-type-provider-typebox/actions/runs/4840171243

If this is okay i can also merge to PR branch

[mcollina]

lgtm.

The question on the CI comes if we want to support multiple versions of typebox outside of the current range. In that case, we need to run the tests for each one of those.

[nadhifikbarw]

I will keep CI changes to perform multi version test in my fork next branch, if we do ended up want to support it, I can make another PR ( ping is welcomed )

[mcollina]

lgtm

[mcollina]

Could you send that follow-up PR?

[nadhifikbarw]

@mcollina #80

[rvitaliy]

@nadhifikbarw @mcollina probably we should revert something more, since @sinclair/typebox is a peerDependency instead of dependency (again)
see changes done in this PR https://github.com/fastify/fastify-type-provider-typebox/pull/64/files

[nadhifikbarw]

@rvitaliy reversion work to peer is light, but we keep oscillating on this back and forth, might be great to have final decision from maintainers on this first before doing it.

[mcollina]

That is correct. All package managers now install peerDeps in a way that enable that.