Run error handler when an error occurs in a non-async handler #120

Prinzhorn · 2021-04-26T14:47:10Z

fixes #119

I basically duplicated the other test and removed the async keyword. Without the fix the test would timeout.

Checklist

run npm run test and npm run benchmark
tests and/or benchmarks are included
documentation is changed or added
commit message and code follows the Developer's Certification of Origin
and the Code of conduct

…astify#119

mcollina

lgtm

Run error handler when an error occurs in a non-async handler, fixes f…

e900c85

…astify#119

Prinzhorn changed the title ~~Run error handler when an error occurs in a non-async handler, fixes …~~ Run error handler when an error occurs in a non-async handler Apr 26, 2021

mcollina approved these changes Apr 26, 2021

View reviewed changes

airhorns approved these changes Apr 26, 2021

View reviewed changes

mcollina merged commit 5012f71 into fastify:master Apr 28, 2021

Prinzhorn deleted the error-handler branch April 28, 2021 08:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Run error handler when an error occurs in a non-async handler #120

Run error handler when an error occurs in a non-async handler #120

Prinzhorn commented Apr 26, 2021 •

edited

Loading

mcollina left a comment

Run error handler when an error occurs in a non-async handler #120

Run error handler when an error occurs in a non-async handler #120

Conversation

Prinzhorn commented Apr 26, 2021 • edited Loading

Checklist

mcollina left a comment

Choose a reason for hiding this comment

Prinzhorn commented Apr 26, 2021 •

edited

Loading