Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check for server.clients undefined #144

Conversation

tinchoz49
Copy link
Contributor

@tinchoz49 tinchoz49 commented Aug 12, 2021

Hi,

I found that if I have the websocket option clientTracking in false it throws an error during the server.close() because server.clients is undefined and the plugin expect always an iterable.

Checking for the server.clients undefined fix the issue.

Checklist

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 48c1264 into fastify:master Aug 13, 2021
@Eomm Eomm mentioned this pull request Nov 14, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants