Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding connectionOptions as a plugin option to enable Duplex options #186

Merged
merged 3 commits into from
Mar 22, 2022

Conversation

aelnaiem
Copy link
Contributor

Enabling connection options to solve a problem described in this issue.

npm run test

 PASS  test/base.js 46 OK 1s
 PASS  test/hooks.js 31 OK 10s
 PASS  test/router.js 57 OK 310.553ms



  🌈 SUMMARY RESULTS 🌈


Suites:   3 passed, 3 of 3 completed
Asserts:  134 passed, of 134
Time:   13s
----------|---------|----------|---------|---------|-------------------
File      | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
----------|---------|----------|---------|---------|-------------------
All files |     100 |      100 |     100 |     100 |
 index.js |     100 |      100 |     100 |     100 |
----------|---------|----------|---------|---------|-------------------

Copy link
Member

@airhorns airhorns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! LGTM after fixing tests, looks like there might be some old node version incompatabilities

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aelnaiem
Copy link
Contributor Author

Great! Is anything else needed before this can be deployed?

@airhorns airhorns merged commit 8e6cd35 into fastify:master Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants