Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: generic type error of RouteShorthandMethod #282

Merged
merged 1 commit into from
Dec 26, 2023
Merged

fix: generic type error of RouteShorthandMethod #282

merged 1 commit into from
Dec 26, 2023

Conversation

XHFkindergarten
Copy link
Contributor

@XHFkindergarten XHFkindergarten commented Dec 19, 2023 •
edited by Fdawgs
Loading

closes #280

Checklist

@fastify fastify deleted a comment from XHFkindergarten Dec 19, 2023
mcollina
mcollina reviewed Dec 19, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test for this type change? We use tsd.

@XHFkindergarten
Copy link
Contributor Author

Could you add a test for this type change? We use tsd.

done，I think a default type check is enough.

mcollina
mcollina approved these changes Dec 26, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit d7462d8 into fastify:master Dec 26, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@airhorns airhorns airhorns approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix a typescript generic type error
3 participants
@XHFkindergarten @mcollina @airhorns