Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Websocket Types #284

Merged
merged 1 commit into from
Dec 26, 2023
Merged

Fix Websocket Types #284

merged 1 commit into from
Dec 26, 2023

Conversation

bstka
Copy link
Contributor

@bstka bstka commented Dec 20, 2023

Fix Websocket Types: TS1259 because "ws" package using "export =" #283

Test:

$ npm run test:unit && npm run test:typescript

> @fastify/websocket@8.3.0 test:unit
> tap

 PASS ​ test/base.test.js 36 OK 1s
 PASS ​ test/hooks.test.js 39 OK 195.977ms
 PASS ​ test/router.test.js 56 OK 250.149ms


                         
  🌈 SUMMARY RESULTS 🌈  
                         

Suites:   ​3 passed​, ​3 of 3 completed​
Asserts:  ​​​131 passed​, ​of 131​
Time:​   ​3s​
----------|---------|----------|---------|---------|-------------------
File      | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s 
----------|---------|----------|---------|---------|-------------------
All files |     100 |      100 |     100 |     100 |                   
 index.js |     100 |      100 |     100 |     100 |                   
----------|---------|----------|---------|---------|-------------------

> @fastify/websocket@8.3.0 test:typescript
> tsd

Done in 8.51s.

Checklist

Fixing Unresolved Types for `websocketServer`
@bstka bstka changed the title Update index.d.ts Fix Websocket Types Dec 20, 2023
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 5029856 into fastify:master Dec 26, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants