Fix PluginOptions incorrect typings #53
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 👋
First of all, thanks @mcollina, @delvedor & all contributors for the awesome
fastify
ecosystem. I had just recently dived into it & I'm very impressed.Moving on to the issue on hand, I found out that the TS typing provided for
PluginOptions
(used infastify.register(ws, opts \*here*\)
is incorrect: the typings requires bothhandler
andoptions
to be passed in. I looked into the docs & code to verify that it has defaults specified.I fixed this in this PR, and had added tests to cover this use-case. Additionally, I did minor clean-up on the declaration file.
I think this addresses #47 too.
Checklist
npm run test
andnpm run benchmark
(I couldn't findnpm run bench
nornpm run benchmark
, should the PR template be updated?)