Update TypeScript types to match actual request object passed to handlers #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lers In the README it states (and in my experience also) the handler doesn't get a full on `FastifyRequest` object. It gets an `http.IncomingMessage` instead! This makes the TypeScript types reflect that.
|
Fixes #60 |
airhorns
added a commit
to airhorns/fastify-websocket
that referenced
this pull request
Jul 16, 2020
This corrects an issue introduced in fastify#64 where upon adding `fastify-websocket` to a project all route handlers were (accidentally) assumed to be websocket handlers getting the different (and decidedly less useful) types. My bad! This corrects the issue by using a type-land overload of the RouteShorthand function definition to change the type of the handler only if the handler is in fact `{ websocket: true }`. Also adds tests, `tsd` is handy!
4 tasks
airhorns
pushed a commit
to airhorns/fastify-websocket
that referenced
this pull request
Jul 16, 2020
This corrects an issue introduced in fastify#64 where upon adding `fastify-websocket` to a project all route handlers were (accidentally) assumed to be websocket handlers getting the different (and decidedly less useful) types. My bad! This corrects the issue by using a type-land overload of the RouteShorthand function definition to change the type of the handler only if the handler is in fact `{ websocket: true }`. Also adds tests, `tsd` is handy!
airhorns
pushed a commit
to airhorns/fastify-websocket
that referenced
this pull request
Jul 16, 2020
This corrects an issue introduced in fastify#64 where upon adding `fastify-websocket` to a project all route handlers were (accidentally) assumed to be websocket handlers getting the different (and decidedly less useful) types. My bad! This corrects the issue by using a type-land overload of the RouteShorthand function definition to change the type of the handler only if the handler is in fact `{ websocket: true }`. Also adds tests, `tsd` is handy!
mcollina
added a commit
that referenced
this pull request
Jul 17, 2020
…#68) This corrects an issue introduced in #64 where upon adding `fastify-websocket` to a project all route handlers were (accidentally) assumed to be websocket handlers getting the different (and decidedly less useful) types. My bad! This corrects the issue by using a type-land overload of the RouteShorthand function definition to change the type of the handler only if the handler is in fact `{ websocket: true }`. Also adds tests, `tsd` is handy! Co-authored-by: Matteo Collina <hello@matteocollina.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the README it states (and in my experience also) the handler doesn't get a full on
FastifyRequestobject. It gets anhttp.IncomingMessageinstead! This makes the TypeScript types reflect that.Checklist
npm run testandnpm run benchmark