Feature/addSchema to serialization #1437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollina
reviewed
Feb 6, 2019
| | `$ref` to `$id` | ✔ | ✔️ | | ||
| | `$ref` to `/definitions` | ✔️ | ✔️ | | ||
| | `$ref` to shared schema `$id` | ❌ | ✔️ | | ||
| | `$ref` to shared schema `/definitions` | ❌ | ✔️ | |
There was a problem hiding this comment.
I think it would be good to add some examples
mcollina
approved these changes
Feb 8, 2019
|
Yes! Because I filtered only the |
|
Can you send a backport PR to 1.x with 972f2e7? |
|
Sure 👍 |
|
Is this a semver minor or a bugfix? |
|
It is a semver patch. The PR title is misleading 😅 |
4 tasks
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this PR fixes #1410 and add more tests for some use cases of JSON-schema.
Regarding the table for the compatibility, I have tested the not covered use cases (I will open an issue to implement them. Here a GIST as test)
Checklist
npm run testandnpm run benchmark