Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add res serializer to docs #1455

Merged
merged 3 commits into from
Mar 10, 2019
Merged

Add res serializer to docs #1455

merged 3 commits into from
Mar 10, 2019

Conversation

open-source-explorer
Copy link
Contributor

Closes #1316

Add res serializer to docs

@open-source-explorer
Copy link
Contributor Author

@mcollina What do you think?

cemremengu
cemremengu reviewed Feb 18, 2019
View reviewed changes
Copy link
Contributor

@cemremengu cemremengu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add this above the line This option will be ignored by any logger other than Pino. describing what it does like:

For example, the response payload can be logged using the approach below

@open-source-explorer
Copy link
Contributor Author

@cemremengu hope it's fine now 👍

cemremengu
cemremengu approved these changes Feb 19, 2019
View reviewed changes
Copy link
Contributor

@cemremengu cemremengu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mcollina
mcollina reviewed Feb 19, 2019
View reviewed changes
@delvedor delvedor added the documentation Improvements or additions to documentation label Feb 26, 2019
@mcollina
Copy link
Member

mcollina commented Mar 8, 2019

@open-source-explorer would you be able to address the requested changes?

@open-source-explorer
Copy link
Contributor Author

@mcollina What do you think now?

mcollina
mcollina approved these changes Mar 10, 2019
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit d785957 into fastify:master Mar 10, 2019
This was referenced Jun 9, 2019
Open
Merged
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mcollina mcollina mcollina approved these changes

@cemremengu cemremengu cemremengu approved these changes

@Eomm Eomm Eomm approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@open-source-explorer @mcollina @cemremengu @Eomm @delvedor