Fix: call preHandler on reply.callNotFound

[salmanm]

Fixes #2229

Checklist

• run npm run test and npm run benchmark
• tests and/or benchmarks are included
• documentation is changed or added
• commit message and code follows Code of conduct

[delvedor]

Hello! Thank you for the pr.
I think we should reuse the preHandlerCallback present in lib/handleRequest.js

fastify/lib/handleRequest.js

Lines 107 to 133 in dce32e7

	function preHandlerCallback (err, request, reply) {
	if (reply.sent ||
	reply.raw.writableEnded === true ||
	(reply.raw.writable === false && reply.raw.finished === true)) return
	if (err != null) {
	reply.send(err)
	return
	}
	var result
	try {
	result = reply.context.handler(request, reply)
	} catch (err) {
	reply.send(err)
	return
	}
	if (result !== undefined) {
	if (result !== null && typeof result.then === 'function') {
	wrapThenable(result, reply)
	} else {
	reply.send(result)
	}
	}
	}

As you can see we are also doing more work, namely the synchronous error checking.

[mcollina]

lgtm

[delvedor]

LGTM

[delvedor]

I expect the automatic backport to fail since the preHandlerCallback code has been changed in v3.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.