Use fastify-warning for handling deprecation warnings #2354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delvedor
added
internals
mcollina
reviewed
Jun 27, 2020
mcollina
requested changes
Jun 29, 2020
|
@mcollina @jsumners PTAL. Also review fastify/process-warning#1. |
mcollina
reviewed
Jul 11, 2020
| If you want to deprecate an API, or you want to warn the user about a specific use case, you can use the [`fastify-warning`](https://github.com/fastify/fastify-warning) module. | ||
|
|
||
| ```js | ||
| const warning = require('fastify-warning')() |
There was a problem hiding this comment.
It would be good to explain why this is a factory.
|
@delvedor what's the state of this? |
Closed
|
@mcollina Sorry, got caught with other stuff :) |
It is already explained in the module documentation :) |
This was referenced Aug 4, 2020
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #2339.
Please, take also a look at fastify/process-warning#1.
Checklist
npm run testandnpm run benchmark