-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use standard and @fastify/pre-commit #190
Conversation
Pull Request Test Coverage Report for Build 2948849632Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm generically -1 in changing the formatting of some code.
I have no strong opinion but it's just cosmetic :) |
@aboutlo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm +1 to ease the maintenance across repos by adopting the same structure.
We are free to experiment on personal repos tho
no strong opinion, but given others signalled in favor and we can standardise towards what other repo do I will merge it |
Checklist
npm run test
andnpm run benchmark
and the Code of conduct