Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: stop failing action when bump is higher than target and log info instead #424

Merged
merged 3 commits into from
May 19, 2023

Conversation

guilhermelimak
Copy link
Contributor

This stops the action from failing when target is not match, just log a message instead.

Resolves #423.

Checklist

Copy link
Collaborator

@simoneb simoneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. On paper this is a breaking change because it changes an existing behavior from failing the execution to logging a warning, but in practice I believe it's a safe change to do.

@simoneb simoneb merged commit fe8e51f into fastify:main May 19, 2023
@github-actions github-actions bot mentioned this pull request May 24, 2023
@guilhermelimak guilhermelimak deleted the feat/change-target-skip-to-log branch June 12, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Skip" out of range updates (e.g. comment, log entry) rather than failing the pipeline
2 participants