Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: restrict to only run for pull_request triggers #501

Conversation

dancamma
Copy link

Closes #498

This PR restricts the action to only run for pull_request triggers. For more details, see #355

Checklist

@diranged
Copy link
Contributor

This seems like the opposite of the conversation in #355 and #500... whats the motivation to make it even harder to run this on a pull_request_target build? (or frankly any trigger that the repo author feels is valid)?

@simoneb
Copy link
Collaborator

simoneb commented Oct 10, 2023

@diranged because this predates the conversation we just had and the intent was to make it clearer why the action execution failed. I agree we can refocus the effort on making it work instead.

@diranged
Copy link
Contributor

@diranged because this predates the conversation we just had and the intent was to make it clearer why the action execution failed. I agree we can refocus the effort on making it work instead.

Excellent - thanks, I just saw this come in right now and was confused! :)

@dancamma
Copy link
Author

@diranged @simoneb I've just read the update on #355, I'm closing this one

@dancamma dancamma closed this Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail with meaningful error in case an unsupported trigger is used
3 participants