Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cookies property to the InjectOptions interface type definition #74

Merged
merged 2 commits into from
Mar 3, 2020
Merged

Add cookies property to the InjectOptions interface type definition #74

merged 2 commits into from
Mar 3, 2020

Conversation

gyszalai
Copy link
Contributor

@gyszalai gyszalai commented Mar 3, 2020

Checklist

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message and code follows Code of conduct

mcollina
mcollina reviewed Mar 3, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind to add a unit test for this type?

@gyszalai
Copy link
Contributor Author

gyszalai commented Mar 3, 2020

I'm not sure you meant this, please review.

mcollina
mcollina approved these changes Mar 3, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 29204ab into fastify:master Mar 3, 2020
@gyszalai gyszalai deleted the inject_options_cookies branch March 3, 2020 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eomm Eomm Eomm approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gyszalai @mcollina @Eomm