Skip to content

chore: add package-lock #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Fdawgs wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: add package-lock #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e04b8af
chore: add package-lock
Fdawgs Nov 27, 2025
b5c17d2
chore: mark as private
Fdawgs Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .github/workflows/emeritus-check.yml
View file
Open in desktop
Copy link
Member

@Eomm Eomm Nov 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternative is we disable the caching in the workflow?

I tend to agree with that

Copy link
Member Author

@Fdawgs Fdawgs Nov 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Eomm, okay so should i revert all of this and just remove the caching?

Copy link
Member

@Eomm Eomm Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, no pro on that

Original file line number Diff line number Diff line change
Expand Up @@ -21,18 +21,19 @@ jobs:

steps:
- name: Checkout repository
uses: actions/checkout@v5
uses: actions/checkout@v6
with:
persist-credentials: false

- name: Setup Node.js
uses: actions/setup-node@v4
uses: actions/setup-node@v6
with:
check-latest: true
node-version: "24"
cache: "npm"

- name: Install dependencies
run: npm i --ignore-scripts
run: npm ci --ignore-scripts

- name: Run emeritus check
env:
Expand Down
1 change: 0 additions & 1 deletion .npmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
ignore-scripts=true
package-lock=false
Loading