Type of templates property in PointOfViewOptions show allow arrays (#359

) * fix: updated templates type to string or string[] closes #352 * fix: added tests for templates string and string[]
fastify · Jan 13, 2023 · 134ff28 · 134ff28
1 parent 7564b67
commit 134ff28
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 1 deletion.
diff --git a/types/index.d.ts b/types/index.d.ts
@@ -33,7 +33,7 @@ declare namespace fastifyView {
       liquid?: any;
       dot?: any;
     };
-    templates?: string;
+    templates?: string | string[];
     includeViewExtension?: boolean;
     options?: object;
     charset?: string;

diff --git a/types/index.test-d.ts b/types/index.test-d.ts
@@ -69,3 +69,25 @@ expectType<Promise<string>>(app.view("/index", {}, { layout: "/layout-ts"}))
 expectAssignable<FastifyViewOptions>({ engine: { twig: require('twig') }, propertyName: 'mobile' })
 
 expectDeprecated({} as PointOfViewOptions)
+
+const nunjucksApp = fastify()
+
+nunjucksApp.register(fastifyView, {
+  engine: {
+    nunjucks: require('nunjucks'),
+  },
+  templates: [
+    'templates/nunjucks-layout',
+    'templates/nunjucks-template'
+  ],
+})
+
+nunjucksApp.get('/', (request, reply) => {
+  reply.view('index.njk', { text: 'Sample data' })
+})
+
+expectType<Promise<string>>(nunjucksApp.view('/', { text: 'Hello world' }))
+
+expectAssignable<FastifyViewOptions>({ engine: { nunjucks: require('nunjucks') }, templates: 'templates' })
+
+expectAssignable<FastifyViewOptions>({ engine: { nunjucks: require('nunjucks') }, templates: ['templates/nunjucks-layout', 'templates/nunjucks-template']})