Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edge.js templates #417

Open
2 tasks done
johntom opened this issue Feb 28, 2024 · 7 comments
Open
2 tasks done

edge.js templates #417

johntom opened this issue Feb 28, 2024 · 7 comments
Labels
feature request New feature to be added good first issue Good for newcomers

Comments

@johntom
Copy link

johntom commented Feb 28, 2024

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the feature has not already been requested

🚀 Feature Proposal

I just came across edge.js templates from "htmx discord link" and think this would be a strong addition to point-of-view.

Motivation

While I'm currently using nunjucks as my templating engine, many users on discord feel they will never add partials which is a feature I'd like to test with htmx. I also find https://edgejs.dev/docs/introduction very clear and concise.

Example

No response

@mcollina mcollina added the feature request New feature to be added label Feb 29, 2024
@mcollina
Copy link
Member

Thanks for reporting! Would you like to send a Pull Request to address this issue? Remember to add unit tests.

@johntom
Copy link
Author

johntom commented Feb 29, 2024

Sure, sorry to say that I've never done a pull request so I'm reading your guidelines now and will make an attempt.

@gurgunday gurgunday added the good first issue Good for newcomers label Mar 1, 2024
@multivoltage
Copy link
Contributor

never read about this engine. It's seem very big.
I loved what they wrote:

If you swim in the <your-frontend-framework> ecosystem, you do not need Edge. Imagine, you never opened this website 😉

@johntom if you want help/collaborate I'm happy

@johntom
Copy link
Author

johntom commented Mar 3, 2024

Yes would love the help and I don't think I'll have any issues with a pull request(pr) but have not gotten edge to work with fastify so didnt have anything to contribute,
Do you want me to do the pr?

@johntom
Copy link
Author

johntom commented Mar 4, 2024

Ok, I think I have successfully created a pull request.

@mweberxyz
Copy link
Contributor

mweberxyz commented Mar 26, 2024

I am not sure edge is a great fit for this plugin. Looking at https://edgejs.dev/docs/getting_started, it is ESM-only (whereas this entire plugin is CommonJS).

@johntom
Copy link
Author

johntom commented Mar 27, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature to be added good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants