Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue#29, set default charset - second try #35

Merged
merged 3 commits into from
Feb 1, 2018
Merged

Issue#29, set default charset - second try #35

merged 3 commits into from
Feb 1, 2018

Conversation

smartiniOnGitHub
Copy link
Contributor

Issue#29, set default charset and simplify/update tests and example applications, pages and docs - second try.
Note that his time I added even some commented line in sources, just a minimal sample (to try to clarify usage of some options).

@smartiniOnGitHub
Copy link
Contributor Author

@mcollina @delvedor I tested the code and all seems to work (all tests and both example server applications), tell me if there is something to change.
Thanks for the great feedback (even before :-) ). Bye

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smartiniOnGitHub
Copy link
Contributor Author

Hi guys, thank you very much :-)

@mcollina mcollina merged commit 2aec1d5 into fastify:master Feb 1, 2018
@smartiniOnGitHub smartiniOnGitHub deleted the issue29-second-try branch February 26, 2018 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants