Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for mustache template engine #65

Merged
merged 1 commit into from
Jul 29, 2018
Merged

Add support for mustache template engine #65

merged 1 commit into from
Jul 29, 2018

Conversation

dtex
Copy link
Contributor

@dtex dtex commented Jul 28, 2018

No description provided.

mcollina
mcollina approved these changes Jul 29, 2018
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit 8c6b8cc into fastify:master Jul 29, 2018
@dtex
Copy link
Contributor Author

dtex commented Jul 29, 2018

Matteo, I am so sorry but I just realized something I don't like about this PR. The "main" template is passed as a path to the template file but the options.partials parameter expects those templates to be passed as strings (already loaded from fs by user code). I think if POV is loading the main template from the file system it should also load the partials.

See this comment for mote context

@mcollina
Copy link
Member

Can you please send an amending PR with the change?

@dtex dtex mentioned this pull request Aug 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dtex @mcollina