Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use tap instead of ava, 100% test coverage, move types to types folder, activate linting in ci-pipeline #65

Merged
merged 6 commits into from
Aug 18, 2022

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Aug 17, 2022

Checklist

Copy link
Member

@Fdawgs Fdawgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know enough about tap to approve that bit, but the rest LGTM.

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Aug 18, 2022

The only big change of the tap conversion was that ava has this test.serial.cb functionality, which basically spawns a new process for the unit test. This is relevant because we are listening in those two tests on process-events. If the tests run in parallel, then the tests fail, because we are listening on all events.

Tap does not have this convenient way to run subtests in an own process. But you just have to extract the subtest to a separate suite and it runs in a separate process.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 6090363 into fastify:master Aug 18, 2022
@Uzlopak Uzlopak deleted the refactor branch August 18, 2022 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants