Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(index): use \d over number range character class in regex #56

Merged
merged 2 commits into from
Oct 21, 2023
Merged

refactor(index): use \d over number range character class in regex #56

merged 2 commits into from
Oct 21, 2023

Conversation

Fdawgs
Copy link
Member

@Fdawgs Fdawgs commented Oct 21, 2023

Same thing, and saves a few bytes.

Checklist

@Fdawgs Fdawgs marked this pull request as draft October 21, 2023 09:48
@Fdawgs Fdawgs marked this pull request as ready for review October 21, 2023 09:51
Uzlopak
Uzlopak approved these changes Oct 21, 2023
View reviewed changes
Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering how much traffic we save when we just release a new version for this change. :P

@Fdawgs
Copy link
Member Author

Fdawgs commented Oct 21, 2023

Wondering how much traffic we save when we just release a new version for this change. :P

Tons. Every company will drop their internal stack and start using Fastify for everything.

@Fdawgs Fdawgs merged commit 2c1a45b into master Oct 21, 2023
15 checks passed
@Fdawgs Fdawgs deleted the Fdawgs-patch-1 branch October 21, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Uzlopak Uzlopak Uzlopak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fdawgs @Uzlopak