Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use new CI #63

Merged
merged 2 commits into from
Apr 24, 2024
Merged

use new CI #63

merged 2 commits into from
Apr 24, 2024

Conversation

gurgunday
Copy link
Member

@gurgunday gurgunday commented Apr 24, 2024

Uses fastify/workflows@4.2.0 instead of a separate workflow

@gurgunday
Copy link
Member Author

gurgunday commented Apr 24, 2024

Just realized currently we don't test types, the test script only does unit tests, so either we modify the test script to remove tsd, or we update node versions...

- name: Run tests
run: npm run test:unit

@gurgunday gurgunday changed the base branch from master to next April 24, 2024 11:40
@gurgunday gurgunday requested a review from Fdawgs April 24, 2024 11:41
@gurgunday
Copy link
Member Author

gurgunday commented Apr 24, 2024

So even if we no longer test for node 10,we'd technically not be breaking but I still pointed to next to align with others

@gurgunday gurgunday merged commit 05a577f into fastify:next Apr 24, 2024
17 checks passed
@gurgunday gurgunday deleted the new-workflow branch April 24, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants