Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If restarting fails, the server must be kept responsive #31

Merged
merged 2 commits into from
Oct 5, 2022

Conversation

mcollina
Copy link
Member

@mcollina mcollina commented Oct 5, 2022

Signed-off-by: Matteo Collina hello@matteocollina.com

Fixes platformatic/platformatic#85

Checklist

Signed-off-by: Matteo Collina <hello@matteocollina.com>
index.js Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
index.js Show resolved Hide resolved
Signed-off-by: Matteo Collina <hello@matteocollina.com>
Copy link
Member

@ivan-tymoshenko ivan-tymoshenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit 1b6333c into main Oct 5, 2022
@mcollina mcollina deleted the restart-after-failure branch October 5, 2022 16:35
Uzlopak pushed a commit that referenced this pull request Dec 4, 2022
* If restarting fails, the server must be kept responsive

Signed-off-by: Matteo Collina <hello@matteocollina.com>

* fixup

Signed-off-by: Matteo Collina <hello@matteocollina.com>

Signed-off-by: Matteo Collina <hello@matteocollina.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

server becomes unavailable after reload if plugin fails to start
2 participants