Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Fastify v5 #113

Merged
merged 3 commits into from
Apr 22, 2024
Merged

Update for Fastify v5 #113

merged 3 commits into from
Apr 22, 2024

Conversation

gurgunday
Copy link
Member

No description provided.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to drop old nodes for this

@gurgunday
Copy link
Member Author

gurgunday commented Apr 16, 2024

We just add pre-commit here now

We can close the PR or just merge to master

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Member

why target next? This can land in main

@gurgunday gurgunday changed the base branch from next to master April 16, 2024 21:15
@gurgunday
Copy link
Member Author

gurgunday commented Apr 16, 2024

I might try to migrate to tap or node:test before merging

@gurgunday gurgunday marked this pull request as draft April 16, 2024 21:16
@gurgunday gurgunday marked this pull request as ready for review April 17, 2024 10:56
@mcollina mcollina merged commit 06c47de into fastify:master Apr 22, 2024
16 checks passed
@gurgunday gurgunday deleted the v5 branch July 6, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants