fix: support parsing buffers #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
charCodeAt is needed in that place. We should convert to string before parsing. |
|
@mcollina Probably it's not ideal that no tests are failing despite that operation being needed. Should we add a test with Buffer that includes BOM in it? |
kibertoad
approved these changes
Jan 9, 2021
|
Thanks for reviewing! Updated and added an extra test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm run testandnpm run benchmarkand the Code of conduct
Summary
When
parseis called with a Buffer, an error was being thrown because we were attempting to call text.charCodeAt which doesn't exist for buffers. This simply adds a check if charCodeAt exists before attempting to invoke it.