Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropped .npmignore #24

Merged
merged 1 commit into from
Feb 17, 2021
Merged

Dropped .npmignore #24

merged 1 commit into from
Feb 17, 2021

Conversation

mcollina
Copy link
Member

@mcollina mcollina commented Feb 17, 2021

Fixes #24

Checklist

Copy link
Member

@L2jLiga L2jLiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit 2952652 into master Feb 17, 2021
@mcollina mcollina deleted the remove-npmignore branch February 17, 2021 14:17
@kibertoad
Copy link
Member

@mcollina Shouldn't files be added to package.json then? Now we are going to be publishing plenty of additional noise files, which can be undesired, especially for browser usage.

@mcollina
Copy link
Member Author

they won't be included in the bundle anyway - we are talking about 4KB that will be downloaded and placed on disk during development.

Managing .npmignore and/or files is just awkward, I just prefer to have all contents pushed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants