-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add types #30
add types #30
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a test test for the types using tsd
?
yep--turns out i made a mistake in the declarations the first time round! should be accurate now. |
looks like tsd doesn't support <10.x (even the versions that claim to support 8.x pull in dependencies that no longer do). |
good for me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Adds typescript types for the
secure-json-parse
functions.The
any
return types are not ideal (it could be better to returnunknown
and force an explicit cast) but this way it's the same asJSON.parse()
.Checklist
npm run test
andnpm run benchmark
and the Code of conduct