Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve performance of normalizeList #38

Merged
merged 1 commit into from
Feb 2, 2023
Merged

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Feb 2, 2023

before:

node benchmarks/normalizeList.js
false x 80,026,396 ops/sec ±1.11% (189 runs sampled)
valid single x 6,009,549 ops/sec ±0.85% (175 runs sampled)
valid array x 56,498,603 ops/sec ±1.91% (175 runs sampled)

after:

node benchmarks/normalizeList.js
false x 1,233,563,481 ops/sec ±0.23% (193 runs sampled)
valid single x 1,230,255,179 ops/sec ±0.24% (194 runs sampled)
valid array x 218,264,955 ops/sec ±0.33% (190 runs sampled)

Checklist

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 0d2e5e8 into master Feb 2, 2023
@Uzlopak Uzlopak deleted the improve-normalizeList branch February 2, 2023 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants