Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Promise API #78

Merged
merged 1 commit into from
Mar 30, 2022
Merged

feat: Promise API #78

merged 1 commit into from
Mar 30, 2022

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Mar 28, 2022 •
edited
Loading

Checklist

Fixes #24.

(note that this includes #77, so just review the last commit)

@SimenB SimenB changed the title feat: add destroy, save and reload to session instance feat: Promise API Mar 28, 2022
@coveralls
Copy link

coveralls commented Mar 28, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2062901442

  • 40 of 40 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 2059716679: 0.0%
Covered Lines: 233
Relevant Lines: 233
💛 - Coveralls

@mcollina
Copy link
Member

what's the semversiness of this?

@SimenB
Copy link
Member Author

SimenB commented Mar 28, 2022 •
edited
Loading

I'd say this is a minor, but #77 (which this PR is based on) is major so they can be bundled together in a new release

@SimenB SimenB mentioned this pull request Mar 29, 2022
Merged
4 tasks
zekth
zekth approved these changes Mar 29, 2022
View reviewed changes
Copy link
Member

@zekth zekth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✌️ great

mcollina
mcollina approved these changes Mar 29, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Member

I've landed the first one and now this conflicts :(.

@SimenB
Copy link
Member Author

SimenB commented Mar 29, 2022

I'll rebase tonight or tomorrow 👍

@SimenB
Copy link
Member Author

SimenB commented Mar 30, 2022

@mcollina done!

@mcollina mcollina merged commit 66ad865 into fastify:master Mar 30, 2022
@SimenB SimenB deleted the promise-api branch March 30, 2022 07:29
@jonaskello jonaskello mentioned this pull request Mar 21, 2024
Open
2 tasks
@bjohansebas bjohansebas mentioned this pull request Dec 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zekth zekth zekth approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Promise API
4 participants
@SimenB @coveralls @mcollina @zekth