Skip to content

ci: set workflow permissions to read-only by default #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Eomm merged 2 commits into from
Apr 3, 2025
Merged

ci: set workflow permissions to read-only by default #294

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f7debc
ci: set workflow permissions to read-only by default
Fdawgs Mar 31, 2025
e5ddb34
ci: remove git credentials after checkout; check latest node version
Fdawgs Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .github/workflows/ci-cd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,14 @@ on:
# daily schedule
workflow_call:

permissions:
contents: read

jobs:
setup:
runs-on: ubuntu-latest
permissions:
contents: read
Copy link
Member

@Eomm Eomm Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to repeat the same code on the job and on the file too?

permissions:
  contents: read

Copy link
Member Author

@Fdawgs Fdawgs Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, it was just for posterity's sake, if we ever need to set to differently from the default then the permissions are already there.

steps:
- name: Select environment
id: env-selector
Expand Down Expand Up @@ -59,13 +64,15 @@ jobs:
if: ${{ github.event_name != 'pull_request_target' }}
uses: actions/checkout@v4
with:
persist-credentials: false
ref: main

- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: 18
cache: npm
check-latest: true
node-version: 18
node-version-file: '.nvmrc'

- name: Install Packages
Expand Down
Loading