Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vsc): remove vsc #60

Closed
wants to merge 3 commits into from
Closed

feat(vsc): remove vsc #60

wants to merge 3 commits into from

Conversation

AugustinMauroy
Copy link
Contributor

@AugustinMauroy AugustinMauroy commented Jan 25, 2023

The idea is that everyone chooses their own configuration of their code editor.

Copy link
Contributor

@HassanBahati HassanBahati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AugustinMauroy is it still necessary to keep the .vcode folder deleted since you have ignored it in the .gitignore

wont those currently using the configurations loose them?

Copy link
Member

@Eomm Eomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm totally against to remove .vscode config.

The rationale:

  • it is used by 74% of devs
  • new developers are more likely to use it, so the suggested extension thing is a helper for junior devs to speed up their productivity and javascript best practices

So we can argue about how to improve the settings because removing it does not add any value to the project itself.

@AugustinMauroy
Copy link
Contributor Author

Could we at least remove the part about mandatory vsc styles?

@Eomm
Copy link
Member

Eomm commented Jan 26, 2023

Could we at least remove the part about mandatory vsc styles?

Sure!

@Eomm Eomm mentioned this pull request Mar 8, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants