Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove git credentials after checkout #28

Merged
merged 1 commit into from
May 19, 2022
Merged

chore: remove git credentials after checkout #28

merged 1 commit into from
May 19, 2022

Conversation

Fdawgs
Copy link
Member

@Fdawgs Fdawgs commented May 19, 2022

See option description at https://github.com/actions/checkout#usage.

We don't use git in any run commands after checking out the repo, so best to just remove the git credentials for security sake.

Checklist

@Fdawgs Fdawgs requested a review from climba03003 May 19, 2022 09:21
climba03003
climba03003 approved these changes May 19, 2022
View reviewed changes
Copy link
Member

@climba03003 climba03003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Fdawgs Fdawgs merged commit a2cea87 into main May 19, 2022
@Fdawgs Fdawgs deleted the chore/git-credentials branch May 19, 2022 10:14
@optic-release-automation optic-release-automation bot mentioned this pull request May 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@climba03003 climba03003 climba03003 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fdawgs @climba03003