Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Apache-2.0 to allowed licenses #50

Merged
merged 1 commit into from
Aug 2, 2022
Merged

add Apache-2.0 to allowed licenses #50

merged 1 commit into from
Aug 2, 2022

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Aug 2, 2022

See fastify/fastify-oauth2#169 (comment)

Only consideration: Dont we need then to ship the code with the text of the Apache-2.0 license?

Checklist

@Fdawgs
Copy link
Member

Fdawgs commented Aug 2, 2022

I believe Apache-2.0 is a permissive license like MIT, however I am not a lawyer

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Aug 2, 2022

I looked over it. I think it is like MIT. As long the license file is in the npm package we should be good.

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Aug 2, 2022

@mcollina

Should we merge and continue the failing projects?

@Fdawgs Fdawgs merged commit 226c0d2 into fastify:main Aug 2, 2022
@Uzlopak Uzlopak deleted the add-apache-2.0 branch August 2, 2022 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants