Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Xcode 11 support with custom output_directory #37

Merged
merged 1 commit into from
Sep 11, 2019
Merged

Enable Xcode 11 support with custom output_directory #37

merged 1 commit into from
Sep 11, 2019

Conversation

xavierLowmiller
Copy link
Contributor

As it is, trainer doesn't substitute .xcresult file endings when an output_directory is set.

This results in trainer generating valid JUnit XML stored in a .xcresult file.

Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Good catch and thanks for the contribution ❤️

@joshdholtz joshdholtz merged commit bb0730b into fastlane-community:master Sep 11, 2019
@xavierLowmiller xavierLowmiller deleted the fix-output-directory branch September 11, 2019 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants