Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show test execution duration #5

Merged
merged 10 commits into from
Aug 31, 2016
Merged

Show test execution duration #5

merged 10 commits into from
Aug 31, 2016

Conversation

liamnichols
Copy link
Contributor

Looks like the latest beta now includes the duration of the tests so i've added support :)
The time attribute is now present on both the test case and suite in the junit ouput 🎉

I also had to regenerate the Valid1.plist and Valid2.plist files from my own Xcode project so i've attached a copy incase anybody else needs to re-generate them in the future... Not sure if that should go into the repo though?

I've never really written any ruby before but the changes are minimal so it wasn't too hard but you might just want to sense check.. Tests all pass though.. Enjoy!

Unit.xcodeproj.zip

@KrauseFx KrauseFx self-assigned this Aug 26, 2016
@@ -18,7 +18,7 @@ Prettify the `xcodebuild` output | :white_check_mark: | :no_entry_sign:
Generate JUnit reports | :white_check_mark: | :white_check_mark:
Generate HTML reports | :white_check_mark: | :no_entry_sign:
Works when the `xcodebuild` output format changed | :no_entry_sign: | :white_check_mark:
Show test execution duration | :white_check_mark: | :no_entry_sign:
Show test execution duration | :white_check_mark: | :white_check_mark:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha, that's awesome 🎉

@KrauseFx
Copy link
Member

Hey @liamnichols, great catch, thanks for your contribution. Could you run rubocop -a to fix some of the code styling issues? 👍

@liamnichols
Copy link
Contributor Author

➜  trainer git:(feautre/duration) ✗ rubocop   
Inspecting 15 files
...............

15 files inspected, no offenses detected

Done 👌

@KrauseFx
Copy link
Member

Thanks for updating the PR, reviewing now 👍

@KrauseFx KrauseFx merged commit 320edd9 into fastlane-community:master Aug 31, 2016
@KrauseFx
Copy link
Member

This is great, I'm preparing a new release right now 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants