-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show test execution duration #5
Merged
KrauseFx
merged 10 commits into
fastlane-community:master
from
liamnichols:feautre/duration
Aug 31, 2016
Merged
Show test execution duration #5
KrauseFx
merged 10 commits into
fastlane-community:master
from
liamnichols:feautre/duration
Aug 31, 2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -18,7 +18,7 @@ Prettify the `xcodebuild` output | :white_check_mark: | :no_entry_sign: | |||
Generate JUnit reports | :white_check_mark: | :white_check_mark: | |||
Generate HTML reports | :white_check_mark: | :no_entry_sign: | |||
Works when the `xcodebuild` output format changed | :no_entry_sign: | :white_check_mark: | |||
Show test execution duration | :white_check_mark: | :no_entry_sign: | |||
Show test execution duration | :white_check_mark: | :white_check_mark: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ha, that's awesome 🎉
Hey @liamnichols, great catch, thanks for your contribution. Could you run |
Done 👌 |
Thanks for updating the PR, reviewing now 👍 |
This is great, I'm preparing a new release right now 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like the latest beta now includes the duration of the tests so i've added support :)
The
time
attribute is now present on both the test case and suite in the junit ouput 🎉I also had to regenerate the
Valid1.plist
andValid2.plist
files from my own Xcode project so i've attached a copy incase anybody else needs to re-generate them in the future... Not sure if that should go into the repo though?I've never really written any ruby before but the changes are minimal so it wasn't too hard but you might just want to sense check.. Tests all pass though.. Enjoy!
Unit.xcodeproj.zip