This repository has been archived by the owner on Nov 19, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 11
Display and output formatting #11
Merged
KrauseFx
merged 11 commits into
fastlane-old:master
from
lacostej:display_and_output_formatting
Sep 3, 2015
Merged
Display and output formatting #11
KrauseFx
merged 11 commits into
fastlane-old:master
from
lacostej:display_and_output_formatting
Sep 3, 2015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lacostej
force-pushed
the
display_and_output_formatting
branch
from
May 21, 2015 10:00
21ea848
to
248649e
Compare
Would have loved to see that one in the latest release :) |
@KrauseFx should we look into merging this at some point ? |
Sorry for the delay, I'll take a look at this today! 👍 |
lacostej
force-pushed
the
display_and_output_formatting
branch
from
September 3, 2015 16:20
248649e
to
092b270
Compare
I updated to latest HEAD + added support for the new country parameter. Code is now ready for review. Maybe we don't need to append information about remaining codes to a file in the display method. |
Looks great, thank you so much for the pull request. Sorry it took so long for me to review it. |
@KrauseFx no problem |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR for #8 and #9. Please review and comment on the following:
When we have addressed everything, I will rebase / squash everything before you can merge.