Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Python version to 3.7 in Netlify #1121

Closed

Conversation

revolter
Copy link
Collaborator

No description provided.

@google-cla google-cla bot added the cla: yes label Nov 20, 2021
@revolter
Copy link
Collaborator Author

Still doesn't work 😡

@revolter revolter closed this Nov 20, 2021
@revolter revolter deleted the update/netlify-python-version branch November 20, 2021 16:20
@janbrasna
Copy link
Contributor

@revolter I understand that’s attempting to fix the netlify builds missing weakref? It seems getting rid of the backports might help, however I have clearly no idea where the env (docker config maybe?) lives, as there’s no reference to weakref in this repo.

Context: pypa/pipenv#4834

@revolter
Copy link
Collaborator Author

revolter commented Dec 8, 2021

@janbrasna, I think that it's a Netlify issue, and they're the one that should fix it. It broke when they updated the docker image that they're using.

@janbrasna
Copy link
Contributor

janbrasna commented Feb 9, 2022

@revolter Gotcha. That's why I couldn't find any of that in the tooling/pipeline;D Good thing is it "fixed itself" (pypa/pipenv#4829) at some point later in December, so one can rely on previews again. 🚀

@janbrasna
Copy link
Contributor

@revolter So I guess it's time to try this again, as the currently used 3.5 in the image does pretty much nothing aside from throwing a jillion of EOL warnings;D — according to https://github.com/netlify/build-image/blob/xenial/included_software.md#languages this value should work. (Can't understand why they default to EOLed version as a the right choice for python3 instead of the highest they support, beyond me:/…)

Otherwise I think it means either specifying exact minor 3.7 in Pipfile (which makes things unnecessarily specific for local work?) or providing runtime.txt with 3.7 (pretty much tidying up these 044d27f + 4240507)?

@janbrasna
Copy link
Contributor

Yea I can only confirm that the .toml file had no impact during my experimenting in #1164 … no idea why:/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants