Add stat for clock runtime #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cratelyn
reviewed
Feb 1, 2022
lib/src/execute.rs
Outdated
| @@ -228,7 +229,7 @@ impl ExecuteCtx { | |||
| remote: IpAddr, | |||
| ) -> Result<(), ExecutionError> { | |||
| info!("handling request {} {}", req.method(), req.uri()); | |||
|
|
|||
| let now = Instant::now(); | |||
There was a problem hiding this comment.
how about renaming this variable ever so slightly, to something like...
Suggested change
| let now = Instant::now(); | |
| let start_timestamp = Instant::now(); |
lib/src/execute.rs
Outdated
| @@ -276,11 +277,15 @@ impl ExecuteCtx { | |||
| .expect("`memory` is exported") | |||
| .size(&store); | |||
|
|
|||
| let distant = Instant::now().duration_since(now); | |||
There was a problem hiding this comment.
...and similarly, a slight name tweak
Suggested change
| let distant = Instant::now().duration_since(now); | |
| let request_duration = Instant::now().duration_since(start_timestamp); |
lib/src/execute.rs
Outdated
| info!( | ||
| "request completed using {} of WebAssembly heap", | ||
| bytesize::ByteSize::kib(heap_pages as u64 * 64) | ||
| ); | ||
|
|
||
| info!("request completed in {:?}", distant); |
There was a problem hiding this comment.
same rename as above, just applying it here so you can fix this with the click of a mouse 🖱️
Suggested change
| info!("request completed in {:?}", distant); | |
| info!("request completed in {:?}", request_duration); |
|
@cratelyn updated 🙏 |
|
this looks like it's almost ready to go @djKooks! there's currently a hiccup in CI here that was addressed in #123. if you rebase this branch on the current |
|
@cratelyn got it. Updated~ |
cratelyn
approved these changes
Feb 7, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #76
(please ignore branch/commit name...)