Allow to enable wasmtime's profiling support #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cratelyn
reviewed
Oct 3, 2022
lib/src/lib.rs
Outdated
Comment on lines
32
to
33
| pub use wasmtime::ProfilingStrategy; | ||
| pub use {error::Error, execute::ExecuteCtx, service::ViceroyService, upstream::BackendConnector}; |
There was a problem hiding this comment.
style nit:
Suggested change
| pub use wasmtime::ProfilingStrategy; | |
| pub use {error::Error, execute::ExecuteCtx, service::ViceroyService, upstream::BackendConnector}; | |
| pub use {error::Error, execute::ExecuteCtx, service::ViceroyService, upstream::BackendConnector, wasmtime::ProfilingStrategy}; |
(this may need to get formatted)
This enables wasmtime's builtin profiling support. https://docs.wasmtime.dev/examples-profiling.html
tetsuharuohzeki
force-pushed
the
support-wasmtime-builtin-profiler
branch
from
68700a4 to
92f35af
Compare
|
Thank you for your review! Could you review again? |
can do! rerunning now... 💭 |
cratelyn
approved these changes
Oct 3, 2022
cratelyn
pushed a commit
that referenced
this pull request
Oct 11, 2022
NB: this is 0.3.0 because breaking changes were introduced in #181.
cratelyn
pushed a commit
that referenced
this pull request
Oct 13, 2022
NB: this is 0.3.0 because breaking changes were introduced in #181.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #180.