feat: allow config-stores to be defined using [local_server.config_stores]
#240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeChampion
force-pushed
the
jake/config-stores
branch
from
939d9f6 to
d2f5329
Compare
JakeChampion
force-pushed
the
jake/config-stores
branch
from
d2f5329 to
b8a4ed3
Compare
JakeChampion
commented
Mar 30, 2023
| @@ -202,6 +202,7 @@ pub enum ExperimentalModule { | |||
| struct RawLocalServerConfig { | |||
| backends: Option<Table>, | |||
| geolocation: Option<Table>, | |||
| #[serde(alias = "config_stores")] | |||
There was a problem hiding this comment.
This is the line which brings in the new functionality -- all the other changes are for tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently they can be defined using
[local_server.dictionaries], this patch adds an alias for[local_server.config_stores]which matches the way we defined object and secret stores (local_server.object_storesandlocal_server.secret_stores)