feat: Allow local KV Stores to be defined using local_server.kv_stores #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeChampion
force-pushed
the
jake/rename-object-store-to-kv-store
branch
from
a65db50 to
5b9ddb6
Compare
KV Store is the new name for Object Store, which is why this is doing an alias between kv_stores and object_stores Future patches will rename the internal implementation and hostcalls from Object Store to KV Store
JakeChampion
force-pushed
the
jake/rename-object-store-to-kv-store
branch
from
5b9ddb6 to
1e7432f
Compare
dennismartensson
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the fastly.toml parser to make
local.server.kv_storesbe equivalent tolocal_server.object_stores.This is intending to be a backwards compatible change 👍
KV Store is the new name for Object Store, which is why this is doing an alias between kv_stores and object_stores.
Future patches will rename the internal implementation and hostcalls from Object Store to KV Store, I've refrained from doing those changes in this pull-request as those would require adding to the witx definitions and I'm not sure what direction we will be taking for that part of the work.