😯 Add support for the new secret from_bytes extension. #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acfoltzer
reviewed
Jul 11, 2023
Comment on lines
+24
to
+28
|
|
||
| // FIXME: uncomment this when we release this API more fully | ||
| //let hello_bytes = "hello, wasm_world!".as_bytes().to_vec(); | ||
| //let secret = Secret::from_bytes(hello_bytes).unwrap(); | ||
| //assert_eq!("hello, wasm_world!", secret.plaintext()); |
There was a problem hiding this comment.
As soon as the 0.9.5 release goes out, I'll update it 😄
There was a problem hiding this comment.
Oh, we have ourselves a circular dependency here, don't we
There was a problem hiding this comment.
Yeah, we can either merge this as is, with a commented-out test case (I can say, I ran it manually and it worked), or we can merge a broken test case and have the SDK release fix it. I think I'd lean towards the former, and then update Viceroy afterwards.
acfoltzer
approved these changes
Jul 11, 2023
JakeChampion
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.