switch default log level to "error", add -v to run #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous default log level was "off", which meant that errors encountered during startup with `viceroy run` were not printed and the process silently failed. For example, this might happen if you had an invalid path in your `fastly.toml` file. In addition, there was no way to turn on verbose log output with `viceroy run`, only in serve mode. This commit moves the default log level to "error", and moves the `-v` flag into the common set. Making "error" the default meant that processes that called `proc_exit` would print WASM stacktraces as errors on exit, but this isn't really an error from the user's perspective, so we check for that (`I32Exit`) and suppress the error message in that case only.
|
@itsrainy I tagged you in as a potential reviewer since you were the last person to recently touch this. If you could take a look I'd appreciate it! |
joeshaw
force-pushed
the
joeshaw/error-logging
branch
from
437d155 to
74b14ff
Compare
itsrainy
approved these changes
Jul 19, 2023
There was a problem hiding this comment.
@joeshaw this seems good to me! If I remember correctly, the reason we initially had the verbosity be off for run-mode was so that cargo-nextest could parse just the output of the underlying wasm test-binary without it being interspersed with Viceroy's logs. I just ran through a couple of tests with this and it seems like having the default be error also works 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous default log level was "off", which meant that errors
encountered during startup with
viceroy runwere not printed and theprocess silently failed. For example, this might happen if you had an
invalid path in your
fastly.tomlfile.In addition, there was no way to turn on verbose log output with
viceroy run, only in serve mode.This commit moves the default log level to "error", and moves the
-vflag into the common set.
Making "error" the default meant that processes that called
proc_exitwould print WASM stacktraces as errors on exit, but this isn't really an
error from the user's perspective, so we check for that (
I32Exit) andsuppress the error message in that case only.