Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤝 Honor backend CA certificates #305

Merged
merged 14 commits into from
Mar 15, 2024
Merged

🤝 Honor backend CA certificates #305

merged 14 commits into from
Mar 15, 2024

Conversation

acw
Copy link
Contributor

@acw acw commented Aug 28, 2023

This should work for both static certificates in the TOML file, presuming you can get them in in a reasonable format, and through dynamic backends.

I've added some test cases, which required adding a serial_test dependency so that the existing client cert test doesn't stomp over the execution requirement. I figured it was nice to leave this functionality in, as there may be more complicated situations in which just using a dynamic backends flag was inconvenient.

@JakeChampion
Copy link
Contributor

@acw is there anything stopping us from merging this work?

@acw acw requested review from fgsch, iximeow and JakeChampion and removed request for iximeow March 13, 2024 19:42
Copy link

@iximeow iximeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

grand, thank you for getting the comments resolved. lets ship it!

fgsch
fgsch previously approved these changes Mar 14, 2024
Copy link
Member

@fgsch fgsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@JakeChampion
Copy link
Contributor

This should work for both static certificates in the TOML file, presuming you can get them in in a reasonable format,

Is there an example of what this reasonable format should look like? Also, would it be possible to supply a filepath instead of in-lining into the TOML file?

@JakeChampion
Copy link
Contributor

@acw would it be possible to have some tests added to /lib/src/config/unit_tests.rs which test out the new fastly.toml fields? 🤞

@acw
Copy link
Contributor Author

acw commented Mar 14, 2024

Is there an example of what this reasonable format should look like?

Only in the test cases. I could put an example config somewhere, but I'm not sure where? Do we have a standard place to put examples?

@acw
Copy link
Contributor Author

acw commented Mar 14, 2024

@JakeChampion Now with tests, which can be showed as examples, and support for file references. Also did arrays, while I was in there, so you can add multiple certs.

@acw acw merged commit 22f3dfd into main Mar 15, 2024
7 checks passed
@acw acw deleted the awick/honor-dynamic-ca-cert branch March 15, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants