-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🤝 Honor backend CA certificates #305
Conversation
@acw is there anything stopping us from merging this work? |
This reverts commit 73a46a5.
…s are not applied.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
grand, thank you for getting the comments resolved. lets ship it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Is there an example of what this reasonable format should look like? Also, would it be possible to supply a filepath instead of in-lining into the TOML file? |
@acw would it be possible to have some tests added to |
Only in the test cases. I could put an example config somewhere, but I'm not sure where? Do we have a standard place to put examples? |
@JakeChampion Now with tests, which can be showed as examples, and support for file references. Also did arrays, while I was in there, so you can add multiple certs. |
This should work for both static certificates in the TOML file, presuming you can get them in in a reasonable format, and through dynamic backends.
I've added some test cases, which required adding a
serial_test
dependency so that the existing client cert test doesn't stomp over the execution requirement. I figured it was nice to leave this functionality in, as there may be more complicated situations in which just using a dynamic backends flag was inconvenient.