Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add async inserts for kv store #329

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Add async inserts for kv store #329

merged 1 commit into from
Nov 6, 2023

Conversation

computermouth
Copy link
Contributor

@computermouth computermouth commented Nov 2, 2023 •
edited by awortman-fastly
Loading

Adding in response to some nudging by @dcaba

@computermouth computermouth requested review from dcaba and aturon November 2, 2023 20:39
dcaba
dcaba approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@dcaba dcaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just focused in the witx changes / everything looks consistent now, thank you

@computermouth computermouth merged commit 6e60112 into main Nov 6, 2023
7 checks passed
@computermouth computermouth deleted the byoung/object-store-async-insert branch November 6, 2023 15:21
cmckendry pushed a commit to 1stdibs/Viceroy that referenced this pull request Feb 8, 2024
@computermouth @cmckendry
Add async inserts for kv store (fastly#329)
0ba8b0e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcaba dcaba dcaba approved these changes

@aturon aturon aturon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@computermouth @aturon @dcaba