New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: assignment fix for constants #99

Merged

vvuksan merged 2 commits into fastly:master from LeMernbag:master-1

Dec 28, 2023

Contributor

LeMernbag commented Aug 25, 2023

Bug:

current conditional only checks whether the key exists, which is does by default, so this always returns true.

Resolution:

check isset() first and then verify that the value isn't empty before assigning it

LeMernbag added 2 commits

August 25, 2023 10:37


          fix: assignment fix for constants

7d89bfe

Validates that the value of the $saved_settings[$key] isn't empty before assigning it


          replace isset with ! empty

416a09f

vvuksan merged commit 0e716fb into fastly:master

LeMernbag deleted the master-1 branch

January 3, 2024 14:12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet